pan/pixelheros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(hero): 移除多余的日志输出并简化代码逻辑

Browse Source 
本次提交清理了多个英雄相关组件中的调试日志，同时简化了条件判断写法：
1.  将多行if判断简化为单行return形式
2.  删除HeroViewComp中护盾特效相关的冗余日志和节点查找逻辑
3.  优化absorbShield和add_shield等方法的代码可读性
This commit is contained in:
panFD
2026-09-04 00:07:36 +08:00
parent 0a3efafbd5
commit 539c30b366
5 changed files with 9 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
assets/script/game/hero/HeroAtkSystem.ts
View File

@@ -518,16 +518,12 @@ export class HeroAtkSystem extends ecs.ComblockSystem implements ecs.ISystemUpda
}
private absorbShield(TAttrsComp: HeroAttrsComp, damage: number): { remainingDamage: number, absorbedDamage: number } {
mLogger.log(this.debugMode, 'HeroAtkSystem', `absorbShield: ${TAttrsComp.hero_name}, shield=${TAttrsComp.shield}, damage=${damage}`);
if (TAttrsComp.shield <= 0) {
mLogger.log(this.debugMode, 'HeroAtkSystem', `absorbShield: shield <= 0, no absorb`);
return { remainingDamage: damage, absorbedDamage: 0 };
}
const absorbed = Math.min(TAttrsComp.shield, damage);
const oldShield = TAttrsComp.shield;
TAttrsComp.shield = Math.max(0, TAttrsComp.shield - absorbed);
TAttrsComp.dirty_shield = true;
mLogger.log(this.debugMode, 'HeroAtkSystem', `absorbShield: ${TAttrsComp.hero_name}, absorbed=${absorbed}, shield ${Math.floor(oldShield)} -> ${Math.floor(TAttrsComp.shield)}, dirty_shield=true`);
return { remainingDamage: damage - absorbed, absorbedDamage: absorbed };
}