Fixes from code review:
Critical:
- Replace module-level `settings = Settings()` with lazy initialization
via `get_settings()` function to avoid import failures when env vars
not set
Important:
- Remove unused `import os` from test_config.py
- Add tests for computed properties (db_path, ssh_keys_dir, repos_dir)
- Add field validation for encrypt_key:
* Validates base64 format
* Ensures decoded key is at least 32 bytes for AES-256
- Fix Python 3.8 compatibility (use Optional[Settings] instead of | union)
All tests pass (6/6).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add Settings class using pydantic-settings
- Load config from environment variables with GM_ prefix
- Support encrypt_key and api_token (required, no defaults for security)
- Provide defaults for data_dir, host, port
- Add computed properties for db_path, ssh_keys_dir, repos_dir
- Add tests for config defaults and environment variable overrides
- Add Base class to app.models to unblock conftest.py imports
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
